Add LBRY UTXO support and local address/transaction tests - #62
Open
tzarebczan wants to merge 2 commits into
Open
tzarebczan wants to merge 2 commits into
tzarebczan wants to merge 2 commits into
Conversation
tzarebczan
force-pushed
the
lbry-support
branch
3 times, most recently
from
January 20, 2021 06:29
b58264f to
ba6a161
Compare
Been chatting with the Ren team on Telegram and we are very eager to add support for renLBC! We're a fork of Bitcoin Core, so integration should be fairly straightforward. Note: Rebased and made updates to LBRY params on 1/20/2021. Happy New Year Ren Team, looking forward to working together.
tzarebczan
force-pushed
the
lbry-support
branch
from
January 22, 2021 06:16
ba6a161 to
b193711
Compare
Author
|
Recently updated with a few fixes + rebase, all tests passing now:
|
tzarebczan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds LBRY as an LBC UTXO chain, with chain-specific address/network parameters, Bitcoin-compatible transaction and fee-estimator adapters, and local-node infrastructure. The branch is updated to current
master; existing upstream chain mappings and the removal of the obsolete Solana Compose service are preserved.Local regression tests cover mainnet/testnet/regtest legacy address round trips, malformed/checksum/wrong-network rejection, LBC/LBRY mappings, exact transaction outputs and fee accounting, and P2PKH script validation. Changing a signed output amount invalidates the signature. The existing root integration case is available through the explicit
-lbcflag.Validation on Go 1.27.1:
go test -mod=readonly -race ./chain/lbry -run '^TestLBRY(Address|Tx)' -count=1— passed (six top-level tests, including twelve address subcases).go build -mod=readonly . ./chain/lbry ./chain/bitcoin ./api/address ./api/utxo— passed.go vet -mod=readonly ./chain/lbry ./chain/bitcoin ./api/address ./api/utxoandgit diff --check— passed.These tests use public synthetic fixtures and no RPC calls. The existing funded-node Ginkgo tests, full multi-chain integration suite, and live LBRY transaction submission were not run. Local script validation does not establish acceptance by a LBRY node. No protocol parameters were changed during this update.